V2 #210
Merged
V2 #210
+343
−338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v2 #210 +/- ##
=============================================
- Coverage 74.05% 26.53% -47.53%
+ Complexity 117 41 -76
=============================================
Files 11 11
Lines 343 343
Branches 42 42
=============================================
- Hits 254 91 -163
- Misses 82 249 +167
+ Partials 7 3 -4
☔ View full report in Codecov by Sentry. |
|
Code coverage is inaccurate (unchanged from v1), had to break it due to dependency issues. Will fix in a future PR. |
willtong1234
approved these changes
Aug 29, 2023
joebaro
approved these changes
Aug 29, 2023
ecraw-amzn
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: Provide a v2 version of the Secrets Manager JDBC Library. Version 2 uses the Secrets Manager Caching library v2 under the hood, which itself uses the AWS Secrets Manager client for Java v2. The major version upgrade be a drop-in replacement for customers. Version 1 and 2 will keep being maintained side-by-side.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.